Skip to content

Conversation

@hehuiyuan
Copy link
Contributor

What is the purpose of the change

doc error

image

@hehuiyuan hehuiyuan changed the title fix hive dim doc replace o to order [DOC]fix hive dim doc replace o to order Mar 19, 2021
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1d534b9 (Fri Mar 19 14:27:47 UTC 2021)

Warnings:

  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 19, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@hehuiyuan
Copy link
Contributor Author

@flinkbot re-run

@hehuiyuan
Copy link
Contributor Author

Hi @lirui-apache ,
please have a look this.

@lirui-apache
Copy link
Contributor

Thanks @hehuiyuan for fixing the doc. It looks good to me, but you need a jira ticket to associate with your PR.

@hehuiyuan
Copy link
Contributor Author

Thanks @hehuiyuan for fixing the doc. It looks good to me, but you need a jira ticket to associate with your PR.

Hi @lirui-apache , okay i do it.

I have changed some documents before, and then others said that simple doc changes do not need to create jira.

@hehuiyuan hehuiyuan changed the title [DOC]fix hive dim doc replace o to order [FLINK-21930][DOC]fix hive dim doc replace o to order Mar 23, 2021
@hehuiyuan
Copy link
Contributor Author

Hi @lirui-apache , done

Copy link
Contributor

@lirui-apache lirui-apache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit 9bcd56c into apache:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants