-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-21887][sql-client] Add SHOW VIEWS test in CliClientITCase #15298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 681e314 (Sat Mar 20 10:26:23 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I only have a minor comment.
| create view c1.`default`.MyView5 as select 1 + 1; | ||
| [INFO] View has been created. | ||
| !info | ||
|
|
||
| create view c1.`default`.MyView6 as select 1 + 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create view `default`.MyView..
To keep align with the above create table?
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
This is just do some code clean before unify the parser. Move the SHOW VIEWS test from the CliClientTest into CliClientITCase. It also removes some usesless codes
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation