Skip to content

[FLINK-3270] Add Kafka example#1533

Closed
rmetzger wants to merge 1 commit into
apache:masterfrom
rmetzger:flink3270
Closed

[FLINK-3270] Add Kafka example#1533
rmetzger wants to merge 1 commit into
apache:masterfrom
rmetzger:flink3270

Conversation

@rmetzger

Copy link
Copy Markdown
Contributor

No description provided.

@StephanEwen

Copy link
Copy Markdown
Contributor

Not quite sure about adding examples for the connectors to the examples project. If we do that for all connectors, it becomes heavily loaded with dependencies.

Can the example not be in the kafka connector project?

@rmetzger

Copy link
Copy Markdown
Contributor Author

I understand that argument, and I would be strongly against adding examples for each connector.

The pull request is moving the example away from the Kafka project into the main Flink examples.
The reasons why I wanted to have Kafka in the main examples:

  • Almost all Flink users I know are using Kafka, so its important to place the example prominently.
  • Its very handy to deploy a Kafka example with the binary distribution to quickly test if flink is properly working on a cluster with Kafka (instead of building a separate project somewhere)

@fhueske

fhueske commented Feb 11, 2016

Copy link
Copy Markdown
Contributor

I think Robert has a good point.
The examples should follow the implementations of the other examples after the rework in PR #1581.

@asfgit asfgit closed this in b6bfcf0 Feb 12, 2016
alkagin pushed a commit to radicalbit/flink that referenced this pull request Feb 12, 2016
subhankarb pushed a commit to subhankarb/flink that referenced this pull request Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants