[FLINK-3270] Add Kafka example#1533
Closed
rmetzger wants to merge 1 commit into
Closed
Conversation
Contributor
|
Not quite sure about adding examples for the connectors to the examples project. If we do that for all connectors, it becomes heavily loaded with dependencies. Can the example not be in the kafka connector project? |
Contributor
Author
|
I understand that argument, and I would be strongly against adding examples for each connector. The pull request is moving the example away from the Kafka project into the main Flink examples.
|
Contributor
|
I think Robert has a good point. |
alkagin
pushed a commit
to radicalbit/flink
that referenced
this pull request
Feb 12, 2016
This closes apache#1533
subhankarb
pushed a commit
to subhankarb/flink
that referenced
this pull request
Mar 17, 2016
This closes apache#1533
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.