[BP-1.11][FLINK-21609][tests] Remove usage of LocalCollectionOutpuFormat from SimpleRecoveryITCaseBase #15453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SimpleRecoveryITCaseBase The LocalCollectionOutputFormat does not work well together with restarts because it records results from different attempts. Hence, instead of using this format we now use the collect() call in the SimpleRecoveryITCaseBase. This closes apache#15389.
…CaseBase Using the resource allows to reuse it across tests and ensures a proper shut down at the end.
…rt strategy agnostic
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 949f34b (Sat Aug 28 11:12:41 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Collaborator
tillrohrmann
added a commit
that referenced
this pull request
Apr 1, 2021
…SimpleRecoveryITCaseBase The LocalCollectionOutputFormat does not work well together with restarts because it records results from different attempts. Hence, instead of using this format we now use the collect() call in the SimpleRecoveryITCaseBase. This closes #15453.
Contributor
Author
|
Merged via efd694a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #15389 to
release-1.11.