Skip to content

Conversation

@hehuiyuan
Copy link
Contributor

What is the purpose of the change

merge FLINK-22021 to Flink 1.12

PushFilterIntoLegacyTableSourceScanRule will throw exception when faced with INTERVAL types, no matter it can be pushed down or not.

This PR fixes this issue.

Brief change log

Fix exception when PushFilterIntoLegacyTableSourceScanRule is faced with INTERVAL types

Verifying this change

This change can be verified by running the added tests.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@hehuiyuan hehuiyuan changed the title Fix exception when PushFilterIntoLegacyTableSourceScanRule is faced … [FLINK-22021][table-planner-blink] Fix exception when PushFilterIntoLegacyTableSourceScanRule is faced with INTERVAL types Apr 14, 2021
@hehuiyuan hehuiyuan changed the title [FLINK-22021][table-planner-blink] Fix exception when PushFilterIntoLegacyTableSourceScanRule is faced with INTERVAL types [FLINK-22021][table-planner-blink] Fix exception when PushFilterIntoLegacyTableSourceScanRule is faced with INTERVAL types (Merge to Flink 1.12) Apr 14, 2021
@hehuiyuan hehuiyuan changed the title [FLINK-22021][table-planner-blink] Fix exception when PushFilterIntoLegacyTableSourceScanRule is faced with INTERVAL types (Merge to Flink 1.12) [FLINK-22021][table-planner-blink] Fix exception when PushFilterIntoLegacyTableSourceScanRule is faced with INTERVAL types Apr 14, 2021
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 14, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a693327 (Sat Aug 28 11:15:08 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 14, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@hehuiyuan hehuiyuan force-pushed the release-1.12-fix-IntervalTypeForPushFilterIntoTableSource branch 2 times, most recently from bf6564c to e49487c Compare April 15, 2021 13:05
@hehuiyuan hehuiyuan force-pushed the release-1.12-fix-IntervalTypeForPushFilterIntoTableSource branch from cf7c959 to a693327 Compare April 18, 2021 06:22
@hehuiyuan
Copy link
Contributor Author

Hi @JingsongLi , please take a look at this PR.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hehuiyuan for your cherry-pick, Looks good to me.

@JingsongLi JingsongLi merged commit 8c146a5 into apache:release-1.12 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants