[FLINK-18206][table-api / sql-client] Fix the incorrect timestamp display#15658
Closed
leonardBang wants to merge 6 commits intoapache:masterfrom
Closed
[FLINK-18206][table-api / sql-client] Fix the incorrect timestamp display#15658leonardBang wants to merge 6 commits intoapache:masterfrom
leonardBang wants to merge 6 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @fsk119 Could you help take a look this PR? |
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit c45fa23 (Sat Aug 28 11:16:39 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Collaborator
wuchong
requested changes
Apr 19, 2021
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliUtils.java
Outdated
Show resolved
Hide resolved
...flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliChangelogResultView.java
Outdated
Show resolved
Hide resolved
...ble/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableResultView.java
Outdated
Show resolved
Hide resolved
...-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientITCase.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
5eac2c7 to
3fb642a
Compare
wuchong
reviewed
Apr 20, 2021
Member
wuchong
left a comment
There was a problem hiding this comment.
I left some final minor comments.
...able/flink-table-common/src/main/java/org/apache/flink/table/utils/TimestampStringUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/PrintUtils.java
Outdated
Show resolved
Hide resolved
flink-table/flink-table-common/src/test/java/org/apache/flink/table/utils/PrintUtilsTest.java
Outdated
Show resolved
Hide resolved
...-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientITCase.java
Outdated
Show resolved
Hide resolved
1a8bf8e to
afdd1ac
Compare
wuchong
pushed a commit
that referenced
this pull request
Apr 21, 2021
xinggit
pushed a commit
to xinggit/flink
that referenced
this pull request
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief change log
DataTimeFormatteris aligned with TimeFormats inflink-table-commonVerifying this change
Add unit test for
PrintUtils, Add ITCase for Sql-ClientDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation