Skip to content

Conversation

@fsk119
Copy link
Member

@fsk119 fsk119 commented Apr 19, 2021

What is the purpose of the change

Remove sql-client-defaults.yaml

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 19, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 445c928 (Sat Aug 28 11:15:53 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 19, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@fsk119
Copy link
Member Author

fsk119 commented Apr 19, 2021

@flinkbot run azure

@fsk119
Copy link
Member Author

fsk119 commented Apr 20, 2021

The failed reason is

Apr 19 15:44:35   Warning  Failed       16s (x3 over 59s)  kubelet            Failed to pull image "test_kubernetes_pyflink_application": rpc error: code = Unknown desc = Error response from daemon: pull access denied for test_kubernetes_pyflink_application, repository does not exist or may require 'docker login': denied: requested access to the resource is denied

trigger test again...

@wuchong
Copy link
Member

wuchong commented Apr 20, 2021

The build is failed

Apr 20 06:11:54 Traceback (most recent call last):
Apr 20 06:11:54   File "setup.py", line 225, in <module>
Apr 20 06:11:54     copy_files(conf_paths, CONF_TEMP_PATH)
Apr 20 06:11:54   File "setup.py", line 52, in copy_files
Apr 20 06:11:54     dst_path = copy(src_path, os.path.join(output_directory, os.path.basename(src_path)))
Apr 20 06:11:54   File "/__w/3/s/flink-python/dev/.conda/lib/python3.7/shutil.py", line 245, in copy
Apr 20 06:11:54     copyfile(src, dst, follow_symlinks=follow_symlinks)
Apr 20 06:11:54   File "/__w/3/s/flink-python/dev/.conda/lib/python3.7/shutil.py", line 120, in copyfile
Apr 20 06:11:54     with open(src, 'rb') as fsrc:
Apr 20 06:11:54 FileNotFoundError: [Errno 2] No such file or directory: '/__w/3/s/flink-dist/../flink-table/flink-sql-client/conf/'

Maybe we should remove "copy SQL client configuration files" entry in dist assemblies.

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit cd3415f into apache:master Apr 20, 2021
wuchong pushed a commit that referenced this pull request Apr 20, 2021
@fsk119 fsk119 deleted the FLINK-22346 branch November 22, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants