Skip to content

[FLINK-21106][docs] Updates Flink docs to refer to the plugin's page#15685

Merged
zentol merged 1 commit intoapache:masterfrom
XComp:FLINK-21106
Apr 20, 2021
Merged

[FLINK-21106][docs] Updates Flink docs to refer to the plugin's page#15685
zentol merged 1 commit intoapache:masterfrom
XComp:FLINK-21106

Conversation

@XComp
Copy link
Copy Markdown
Contributor

@XComp XComp commented Apr 20, 2021

google-java-format plugin 1.7.0.6 was released
(see issue #560). Hence, we do not
have to rely on the patched version of FLINK-21106 anymore.

What is the purpose of the change

We needed the workaround due to a failure described in FLINK-21106.

Brief change log

Updated the logs accordingly.

Verifying this change

  • I tested the new plugin version on
IntelliJ IDEA 2020.2.4 (Community Edition)
Build #IC-202.8194.7, built on November 24, 2020
Runtime version: 11.0.9+11-b944.49 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 10.15.7
GC: ParNew, ConcurrentMarkSweep
Memory: 8108M
Cores: 12
Non-Bundled Plugins: IdeaVIM, CheckStyle-IDEA, Lombook Plugin, com.dubreuia, google-java-format, org.intellij.scala
  • I rebuild the logs verifying that the link refers to the right page on the English and Chinese docs version

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

google-java-format plugin 1.7.0.6 was released
(google/google-java-format#560). Hence, we do not
have to rely on the patched version of FLINK-21106 anymore.
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 20, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit bbb1428 (Sat Aug 28 11:15:49 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zentol zentol self-assigned this Apr 20, 2021
@zentol zentol merged commit 5588bc9 into apache:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants