Skip to content

[FLINK-22406][coordination][tests] Stabilize ReactiveModeITCase#15825

Merged
zentol merged 2 commits intoapache:masterfrom
zentol:22406
May 7, 2021
Merged

[FLINK-22406][coordination][tests] Stabilize ReactiveModeITCase#15825
zentol merged 2 commits intoapache:masterfrom
zentol:22406

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented May 3, 2021

Stabilizes the ReactiveModeITCase by not checking what is actually being deployed, but just asking the JM with what parallelism it currently intends to run the job with.

@flinkbot
Copy link
Collaborator

flinkbot commented May 3, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 7c0de15 (Sat Aug 28 11:17:53 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented May 3, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zentol. The change itself looks good to me. As an improvement, I would suggest enriching the MiniClusterResource with a getRestClusterClient method which constructs the RestClusterClient so that we can talk to the RestServer. This will allow other tests to use a similar pattern as done here.

@zentol zentol force-pushed the 22406 branch 2 times, most recently from d9a74d2 to df5aa04 Compare May 6, 2021 10:12
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR @zentol. LGTM. +1 for merging.

@zentol zentol merged commit 271ac1b into apache:master May 7, 2021
@zentol zentol deleted the 22406 branch May 27, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants