[FLINK-22406][coordination][tests] Stabilize ReactiveModeITCase#15825
[FLINK-22406][coordination][tests] Stabilize ReactiveModeITCase#15825zentol merged 2 commits intoapache:masterfrom
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7c0de15 (Sat Aug 28 11:17:53 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for creating this PR @zentol. The change itself looks good to me. As an improvement, I would suggest enriching the MiniClusterResource with a getRestClusterClient method which constructs the RestClusterClient so that we can talk to the RestServer. This will allow other tests to use a similar pattern as done here.
flink-tests/src/test/java/org/apache/flink/test/scheduling/ReactiveModeITCase.java
Outdated
Show resolved
Hide resolved
d9a74d2 to
df5aa04
Compare
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for updating the PR @zentol. LGTM. +1 for merging.
Stabilizes the ReactiveModeITCase by not checking what is actually being deployed, but just asking the JM with what parallelism it currently intends to run the job with.