Skip to content

[FLINK-19647][Connectors/HBase]Support the limit push down for the hb…#15847

Closed
shouweikun wants to merge 5 commits intoapache:masterfrom
shouweikun:LSW-19647-20210502
Closed

[FLINK-19647][Connectors/HBase]Support the limit push down for the hb…#15847
shouweikun wants to merge 5 commits intoapache:masterfrom
shouweikun:LSW-19647-20210502

Conversation

@shouweikun
Copy link
Copy Markdown
Contributor

@shouweikun shouweikun commented May 6, 2021

…ase connector"

What is the purpose of the change

Support limit push down for HBase connector

Brief change log

  • implements SupportLimitPushdown in HBase1 and HBase2

Verifying this change

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes /no)
  • The serializers: (yes /no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 6, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 062fbbf (Sat Aug 28 11:19:58 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 6, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@shouweikun
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

@shouweikun
Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

@shouweikun
Copy link
Copy Markdown
Contributor Author

@lirui-apache Would u mind taking a review?

@ferenc-csaky
Copy link
Copy Markdown
Contributor

ferenc-csaky commented Sep 27, 2023

@shouweikun Do you have the capacity to update this PR and reopen it against the flink-connector-hbase repo?

@snuyanzin
Copy link
Copy Markdown
Contributor

snuyanzin commented Oct 19, 2023

@shouweikun thanks for your contribution

The Flink HBase connector resides in it's own repository nowadays, if this code change is still relevant, please open the PR in https://github.com/apache/flink-connector-hbase/

@snuyanzin snuyanzin closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants