-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-22697][examples-table] Clean up examples to not use legacy planner anymore #15948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit d94612f (Thu Sep 23 17:20:41 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Airblader
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| + " VALUES ('Hello', 1), ('Ciao', 1), ('Hello', 2)\n" | ||
| + ")\n" | ||
| // name the table and its columns | ||
| + "AS WordTable(word, frequency)\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just trying to understand this based on the grammar in https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/table/sql/queries/overview/#syntax, but it seems the grammar there doesn't allow SELECT * FROM (VALUES …). Maybe we can quickly fix the grammar in the docs here, though somewhat unrelated?
|
Thanks @Airblader for pointing out the invalid grammar. I will fix the bug in the docs in a hotfix commit while merging. |
What is the purpose of the change
Cleans up the
flink-table-examplesmodules. It removes duplicate examples and updates the existing ones. It also adds tests for all of the examples.Brief change log
See commit messages.
Verifying this change
This change added tests and can be verified as follows: subclasses of
ExampleOutputTestBaseDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation