Skip to content

[FLINK-3371] [api breaking] Move TriggerResult and TriggerContext to dedicated classes#1603

Closed
StephanEwen wants to merge 1 commit into
apache:masterfrom
StephanEwen:trigger_own_class
Closed

[FLINK-3371] [api breaking] Move TriggerResult and TriggerContext to dedicated classes#1603
StephanEwen wants to merge 1 commit into
apache:masterfrom
StephanEwen:trigger_own_class

Conversation

@StephanEwen

Copy link
Copy Markdown
Contributor

This change should go into 1.0, because it is API breaking

In order to prepare for adding aligned windows, this PR unnests some classes needed for aligned triggers.

The functionality stays the same, only imports would need to be adjusted by users.

@aljoscha

aljoscha commented Feb 9, 2016

Copy link
Copy Markdown
Contributor

You are not moving TriggerContext because it is specific to Trigger, correct?

Otherwise it looks good to merge. 👍

@StephanEwen

Copy link
Copy Markdown
Contributor Author

Exactly, the AlignedTrigger will have an AlignedTriggerContext without Key/Value state.

StephanEwen added a commit to StephanEwen/flink that referenced this pull request Feb 10, 2016
@asfgit asfgit closed this in 50bd65a Feb 10, 2016
alkagin pushed a commit to radicalbit/flink that referenced this pull request Feb 11, 2016
subhankarb pushed a commit to subhankarb/flink that referenced this pull request Mar 17, 2016
@StephanEwen StephanEwen deleted the trigger_own_class branch August 1, 2016 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants