Skip to content

Conversation

@fapaul
Copy link
Contributor

@fapaul fapaul commented Jun 1, 2021

This changes hardens the DispatcherTest#testJobStatusIsShownDuringTermination
by ignoring the JobMaster shutdown exception when querying for the
expected job status.

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 1, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c608249 (Sat Aug 28 12:14:17 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 1, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is master not affected?

@fapaul
Copy link
Contributor Author

fapaul commented Jun 1, 2021

is master not affected?

With Flink 1.13 obtaining the leadership changed a bit. In both versions, the jobmanager in the tests never becomes the leader but in Flink 1.12 the future will terminate exceptionally nevertheless, contrary to Flink 1.13+.

This changes hardens the DispatcherTest#testJobStatusIsShownDuringTermination
by ignoring the JobMaster shutdown exception when querying for the
expected job status.
@zentol zentol merged commit 9f1de31 into apache:release-1.12 Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants