Skip to content

Conversation

@luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Jun 3, 2021

What is the purpose of the change

To figure out wrong field name when serializer/deserializer throw exceptions while doing serializing/deserializing for json/ csv/avro format.
NOTE: In avro format, only figure out wrong field name when doing serializing for avro will always deserialize succefully even though the type mismatch.

Brief change log

  • Throw exception with error message about which field can't be serialized/deserialized in JsonRowDataSerializationSchema/JsonRowDataDeerializationSchema and CsvRowDataSerializationSchema/CsvRowDataDeserializationSchema

Verifying this change

This change added tests and can be verified as follows:

  • Added tests testSerializationWithTypesMismatch() and testDeserializationWithTypesMismatch() in CsvRowDataSerDeSchemaTest
  • Modified tests testJsonParse() in JsonRowDataSerDeSchemaTest and added test testSerializationWithTypesMismatch() in JsonRowDataSerDeSchemaTest
  • *Added test testSerializationWithTypesMismatch() in AvroRowDataDeSerializationSchemaTest *

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

luoyuxia added 2 commits June 3, 2021 15:26
…serializer throw exceptions while doing serializing/deserializing for json and csv format.
@flinkbot
Copy link
Collaborator

flinkbot commented Jun 3, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e8ecfd5 (Thu Sep 23 17:23:58 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 3, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One last suggestion: Please add comments why we don't need to add try-catch block when using avro format deserialize.

@luoyuxia
Copy link
Contributor Author

luoyuxia commented Jun 7, 2021

@flinkbot run azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants