Skip to content

Conversation

@akalash
Copy link
Contributor

@akalash akalash commented Jun 7, 2021

…ubtasks until the first checkpoint barrier reaches the sink

What is the purpose of the change

Fix the test - IgnoreInFlightDataITCase

Brief change log

  • IgnoreInFlightDataITCase is blocking the map subtasks until the first checkpoint barrier reaches the sink

Verifying this change

The fix test itself

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 7, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 66fd256 (Sat Aug 28 12:16:45 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 7, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @akalash .
I don't fully understand the fix so I asked a couple of questions, PTAL.

@akalash
Copy link
Contributor Author

akalash commented Jun 9, 2021

@rkhachatryan I pushed the separated commit for easing review but then I can merge it with the previous one.

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR @akalash
I still have some concerns (see below).
Besides that one, the test fails locally if I add a 10ms delay before emitting from source with

java.lang.AssertionError: 
Expected: a value less than <125751L>
     but: <125751L> was equal to <125751L>

@akalash
Copy link
Contributor Author

akalash commented Jun 10, 2021

@rkhachatryan I pushed one more version but infinity loop until success doesn't look the best idea. I will think more about it but anyway you can take a look at the last changes.

@akalash
Copy link
Contributor Author

akalash commented Jun 11, 2021

@flinkbot run azure

Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR @akalash!
LGTM

…ubtasks until the first checkpoint barrier reaches the sink
@rkhachatryan
Copy link
Contributor

CI failure unrelated, merging.

@rkhachatryan rkhachatryan merged commit 0cfc645 into apache:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants