-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-22818][runtime] IgnoreInFlightDataITCase is blocking the map s… #16102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 66fd256 (Sat Aug 28 12:16:45 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
rkhachatryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @akalash .
I don't fully understand the fix so I asked a couple of questions, PTAL.
flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
Outdated
Show resolved
Hide resolved
flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
Outdated
Show resolved
Hide resolved
flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
Show resolved
Hide resolved
|
@rkhachatryan I pushed the separated commit for easing review but then I can merge it with the previous one. |
flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
Outdated
Show resolved
Hide resolved
rkhachatryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR @akalash
I still have some concerns (see below).
Besides that one, the test fails locally if I add a 10ms delay before emitting from source with
java.lang.AssertionError:
Expected: a value less than <125751L>
but: <125751L> was equal to <125751L>
flink-tests/src/test/java/org/apache/flink/test/checkpointing/IgnoreInFlightDataITCase.java
Outdated
Show resolved
Hide resolved
|
@rkhachatryan I pushed one more version but infinity loop until success doesn't look the best idea. I will think more about it but anyway you can take a look at the last changes. |
|
@flinkbot run azure |
rkhachatryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR @akalash!
LGTM
…ubtasks until the first checkpoint barrier reaches the sink
|
CI failure unrelated, merging. |
…ubtasks until the first checkpoint barrier reaches the sink
What is the purpose of the change
Fix the test - IgnoreInFlightDataITCase
Brief change log
Verifying this change
The fix test itself
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation