Skip to content

Conversation

@tsreaper
Copy link
Contributor

@tsreaper tsreaper commented Jun 8, 2021

What is the purpose of the change

Currently lookup join condition with CURRENT_DATE fails to filter records. See FLINK-22730 for details. This PR fixes this issue.

Brief change log

  • Add per record code when generating table function collector code for lookup joins

Verifying this change

This change added tests and can be verified by running the added tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

…g table function collector code for lookup joins
@tsreaper
Copy link
Contributor Author

tsreaper commented Jun 8, 2021

@JingsongLi please help with the review.

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 8, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a2b9def (Sat Aug 28 12:16:34 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 8, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@JingsongLi JingsongLi self-requested a review June 10, 2021 02:26
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsreaper Looks good to me.

@JingsongLi JingsongLi merged commit 1635f93 into apache:master Jun 15, 2021
JingsongLi pushed a commit that referenced this pull request Jun 15, 2021
…e function collector code for lookup joins

This closes #16104
luoyuxia pushed a commit to luoyuxia/flink that referenced this pull request Jun 21, 2021
…e function collector code for lookup joins

This closes apache#16104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants