Skip to content

Conversation

@dianfu
Copy link
Contributor

@dianfu dianfu commented Jun 23, 2021

What is the purpose of the change

This pull request fixes ByteArrayWrapperSerializer

Verifying this change

This change added tests and can be verified as follows:

  • Added tests ByteArrayWrapperSerializerTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 23, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5863668 (Thu Sep 23 17:51:56 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@Override
protected ByteArrayWrapper[] getTestData() {
return new ByteArrayWrapper[] {
randomByteArray(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to have the critical cases as dedicated data. The test should include at least one empty array, one short length, one long length (> 256 bytes) and one very long (> 64k). Random arrays can be added, but the important ones should always be in there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to add dedicated data test. Regarding to 64k length, it fails with OutOfMemoryError 1 times every two runs in my desktop and so I change it to 32k (succeed running the test case 10 times) for test stability.

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 23, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@dianfu
Copy link
Contributor Author

dianfu commented Jun 24, 2021

@StephanEwen Thanks a lot for the review. Have updated the PR for the test cases.

@dianfu
Copy link
Contributor Author

dianfu commented Jun 25, 2021

@flinkbot run azure

@dianfu
Copy link
Contributor Author

dianfu commented Jun 27, 2021

@StephanEwen @HuangXingBo Thanks a lot for the review. I'm merging this PR to catch up with the bugfix release of 1.13 as this is a series bug for MapState in Python DataStream API. Feel free to let me know if there is anything we could improve.

@dianfu dianfu closed this in 2a7e7d7 Jun 27, 2021
dianfu added a commit that referenced this pull request Jun 27, 2021
dianfu added a commit that referenced this pull request Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants