Skip to content

Conversation

@rmetzger
Copy link
Contributor

Cancelling one of multiple running jobs in AppMode is not properly supported.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 63b4d23 (Thu Jun 24 13:16:30 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 24, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build


Additionaly, when any of multiple running jobs in Application Mode (submitted for example using
`executeAsync()`) gets cancelled, all jobs will be stopped and the JobManager shuts down.
Finishing (by the sources shutting down) of any of multiple running jobs is supported.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this a bit unclear, since finishing a job is not an active action triggered by the user. What do you think of something along the lines of "Regular job completions (by the sources shutting down) are supported."?

rmetzger and others added 2 commits June 25, 2021 08:21
Co-authored-by: Nicolaus Weidner <nicolaus.weidner@tngtech.com>
@rmetzger
Copy link
Contributor Author

Thanks a lot for your review. I addressed all your comments.

@rmetzger rmetzger closed this in 18a95ca Jun 25, 2021
rmetzger added a commit that referenced this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants