[FLINK-3226] Translate logical joins to physical #1632
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // FlatJoinFunction | ||
| else if (clazz == classOf[FlatJoinFunction[_,_,_]]) { | ||
| val inputTypeTerm1 = boxedTypeTermForTypeInfo(input1) | ||
| val inputTypeTerm2 = boxedTypeTermForTypeInfo(input2.get) //TODO check this |
Contributor
There was a problem hiding this comment.
Why don't you call getOrElse here and throw an CodeGenException if input2 is not present? Then we can get rid of the TODO.
Contributor
Author
|
Thanks for the review @twalthr! I've addressed your comments. |
Contributor
|
Thanks for the changes. Looks good to merge ;-) |
Contributor
Author
|
Great, merging this also. |
asfgit
pushed a commit
that referenced
this pull request
Feb 15, 2016
vasia
added a commit
to vasia/flink
that referenced
this pull request
Mar 16, 2016
asfgit
pushed a commit
that referenced
this pull request
Mar 18, 2016
fijolekProjects
pushed a commit
to fijolekProjects/flink
that referenced
this pull request
May 1, 2016
hequn8128
pushed a commit
to hequn8128/flink
that referenced
this pull request
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the logical to physical translation for joins.
FlatJoinFunction.in1.join.in2.where(a > b)are currently not supported. We could consider supporting those later by generating a cross function.