Skip to content

Conversation

@rovo98
Copy link
Contributor

@rovo98 rovo98 commented Jul 2, 2021

What is the purpose of the change

To fix broken javadoc inline link.

Brief change log

Fixed javadoc inline link

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 2, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 6d73e9b (Fri Jul 02 01:29:11 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 2, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@rovo98
Copy link
Contributor Author

rovo98 commented Jul 2, 2021

@flinkbot run azure

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rovo98 The CI failed due to spotless-check, you could check the problem in the CI results and update your PR then.

@rovo98
Copy link
Contributor Author

rovo98 commented Jul 2, 2021

Yes, I have seen the problem before. It seems the previous commit violates the code format, and I have updated (from 6d73e9b to ce116b0 ) the PR following the instruction given by CI results.
(I have setup IDE according to https://ci.apache.org/projects/flink/flink-docs-master/docs/flinkdev/ide_setup/, already run mvn spotless:apply)
What else should I do?Thanks for you review.

@rovo98 rovo98 requested a review from Myasuka July 2, 2021 04:23
@Myasuka
Copy link
Member

Myasuka commented Jul 2, 2021

If you could run mvn clean package successfully localy, let's wait for the result of CI.

@rovo98
Copy link
Contributor Author

rovo98 commented Jul 4, 2021

@Myasuka Sorry for the delay reply. The CI result is success, Would you consider to help merging this PR ? thanks.

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reminder, LGTM

@Myasuka Myasuka merged commit 69e1031 into apache:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants