[FLINK-3401] [api breaking] AscendingTimestampExtractor only logs violations #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o two separate classes - one class handled periodic watermarks - the other class handled watermarks triggered by elements This also makes sure that any timestamp assigner / watermark generators cannot generate negative watermarks
…nly logs violations of ascending timestamp order. The user can also explicitly set an 'IgnoringHandler' or a 'FailingHandler', which do nothing on violations, respectively fail hard.
Contributor
Author
|
Manually merged in e08d7a6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests is based on #1646
The AscendingTimestampExtractor only logs violations of ascending timestamp order.
Previously it failed hard on a violation. Since that would be in many cases irrecoverable as soon as one order violation happens in the stream, it it changed to by default only log violations.
The user can still explicitly set an 'IgnoringHandler' or a 'FailingHandler', which do nothing on violations,
respectively fail hard as before.