Skip to content

Conversation

@Airblader
Copy link
Contributor

What is the purpose of the change

We're now exposing options classes for connectors and formats as @PublicEvolving so they can be used with the new TableDecriptor / FormatDescriptor APIs (FLIP-129). To allow users to find these more easily, we are moving them to a consistent package.

Brief change log

  • Move connector options for the HBase connector
  • Move the entirety of the datagen, blackhole and print connector
  • Fix some @Internal / @PublicEvolving annotations

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 4, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9ece6e5 (Wed Aug 04 10:59:54 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 4, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@Airblader Airblader force-pushed the FLINK-23192 branch 2 times, most recently from 5a545f3 to 0da18e7 Compare August 5, 2021 09:59
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Airblader. I found one issue that we should fix before merging. Otherwise the changes look good to me. I think we are close to conclude the FLIP-129 story. A followup issue should be to include the path of the *Options class next to the HTML table of the docs generator to easily find the classes.

*/

package org.apache.flink.table.factories.datagen;
package org.apache.flink.connector.datagen.table.datagen;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datagen.table.datagen?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just say this PR is still in draft mode and I definitely would've seen this still. :-)

@Airblader Airblader marked this pull request as ready for review August 5, 2021 13:29
@Airblader Airblader requested a review from twalthr August 5, 2021 13:29
twalthr pushed a commit to twalthr/flink that referenced this pull request Aug 6, 2021
…ckages

We should advertise the following package structure:

For connector options:
org.apache.flink.connector.XX.table.XXConnectorOptions

For format options:
org.apache.flink.formats.XX.XXFormatOptions

[FLINK-23192][connector-hbase] Move HBase table connector options class

[FLINK-23192][table] Move DataGen connector to a proper package

[FLINK-23192][table] Move print sink and split config options

[FLINK-23192][table] Move blackhole connector

[FLINK-23192][table] Move raw format

[FLINK-23192][formats] Mark factories as internal

This closes apache#16708.
@twalthr twalthr closed this in e1ec23f Aug 10, 2021
hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021
…ckages

We should advertise the following package structure:

For connector options:
org.apache.flink.connector.XX.table.XXConnectorOptions

For format options:
org.apache.flink.formats.XX.XXFormatOptions

[FLINK-23192][connector-hbase] Move HBase table connector options class

[FLINK-23192][table] Move DataGen connector to a proper package

[FLINK-23192][table] Move print sink and split config options

[FLINK-23192][table] Move blackhole connector

[FLINK-23192][table] Move raw format

[FLINK-23192][formats] Mark factories as internal

This closes apache#16708.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants