-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-23192][table] Move connector & format options to consistent packages #16708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9ece6e5 (Wed Aug 04 10:59:54 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
5a545f3 to
0da18e7
Compare
twalthr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Airblader. I found one issue that we should fix before merging. Otherwise the changes look good to me. I think we are close to conclude the FLIP-129 story. A followup issue should be to include the path of the *Options class next to the HTML table of the docs generator to easily find the classes.
| */ | ||
|
|
||
| package org.apache.flink.table.factories.datagen; | ||
| package org.apache.flink.connector.datagen.table.datagen; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
datagen.table.datagen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just say this PR is still in draft mode and I definitely would've seen this still. :-)
…ckages We should advertise the following package structure: For connector options: org.apache.flink.connector.XX.table.XXConnectorOptions For format options: org.apache.flink.formats.XX.XXFormatOptions [FLINK-23192][connector-hbase] Move HBase table connector options class [FLINK-23192][table] Move DataGen connector to a proper package [FLINK-23192][table] Move print sink and split config options [FLINK-23192][table] Move blackhole connector [FLINK-23192][table] Move raw format [FLINK-23192][formats] Mark factories as internal This closes apache#16708.
…ckages We should advertise the following package structure: For connector options: org.apache.flink.connector.XX.table.XXConnectorOptions For format options: org.apache.flink.formats.XX.XXFormatOptions [FLINK-23192][connector-hbase] Move HBase table connector options class [FLINK-23192][table] Move DataGen connector to a proper package [FLINK-23192][table] Move print sink and split config options [FLINK-23192][table] Move blackhole connector [FLINK-23192][table] Move raw format [FLINK-23192][formats] Mark factories as internal This closes apache#16708.
What is the purpose of the change
We're now exposing options classes for connectors and formats as
@PublicEvolvingso they can be used with the newTableDecriptor/FormatDescriptorAPIs (FLIP-129). To allow users to find these more easily, we are moving them to a consistent package.Brief change log
@Internal/@PublicEvolvingannotationsVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): yesDocumentation