Skip to content

Conversation

@hapihu
Copy link
Contributor

@hapihu hapihu commented Aug 9, 2021

Translate "Java Lambda Expressions" page into Chinese'

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 9, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9bdaac5 (Mon Aug 09 06:01:11 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 9, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@wuchong
Copy link
Member

wuchong commented Aug 10, 2021

@RocMarshal , do you have time to review this?

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hapihu Thank you for your contribution. I left some comments. Please let me know what's your opinion.

.print();

// or in this example use a tuple subclass instead
// 或者在这个例子中用 Tuple 的子类来替代
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// 或者在这个例子中用 Tuple 的子类来替代->// 也可以像这个示例中使用 Tuple 的子类来替代
Maybe you could do it better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way you suggest looks better.
I'm going to modify it like this.
Thank you for your reviewing.

hapihu and others added 7 commits August 10, 2021 22:59
Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
@hapihu
Copy link
Contributor Author

hapihu commented Aug 11, 2021

Hello, @RocMarshal
Excuse me for taking up your time.
I have finished the modification according to your suggestion.
Would you like to review it for me again.
Thank you very much!

Co-authored-by: Roc Marshal <64569824+RocMarshal@users.noreply.github.com>
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hapihu Good job. LGTM +1.
Now ping @wuchong .

@wuchong
Copy link
Member

wuchong commented Aug 12, 2021

Thanks for the reviewing @RocMarshal and contribution @hapihu .
Merging...

@wuchong wuchong merged commit 887444f into apache:master Aug 12, 2021
@hapihu
Copy link
Contributor Author

hapihu commented Aug 12, 2021

Hello, @RocMarshal
Excuse me for taking up your time.
I have finished the modification according to your suggestion.
Would you like to review it for me again.
Thank you very much!

hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants