Skip to content

Conversation

@tillrohrmann
Copy link
Contributor

In order to harden tests on slow CI, this commit increases the logger-startup-timeout from 30s to 50s.

Copy link
Member

@dmvk dmvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d13fd53 (Fri Aug 13 10:45:21 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 13, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @dmvk. Merging this PR once Azure gives green light.

…estSuccessfulProgramAfterFailure

This commit decreases the parallelism used by the test job in order to reduce the time it takes to deploy
the whole job.

This closes apache#16812.
In order to harden tests on slow CI, this commit increases the logger-startup-timeout from 30s to 50s.

This closes apache#16814.
@tillrohrmann tillrohrmann merged commit c71d260 into apache:master Aug 15, 2021
@tillrohrmann tillrohrmann deleted the FLINK-23732 branch August 15, 2021 10:26
hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021
In order to harden tests on slow CI, this commit increases the logger-startup-timeout from 30s to 50s.

This closes apache#16814.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants