[FLINK-24082][python] Fix Python UDTF to handle properly when the result is a generator of Row#17090
Closed
dianfu wants to merge 5 commits intoapache:release-1.13from
Closed
[FLINK-24082][python] Fix Python UDTF to handle properly when the result is a generator of Row#17090dianfu wants to merge 5 commits intoapache:release-1.13from
dianfu wants to merge 5 commits intoapache:release-1.13from
Conversation
…ult is a generator of Row
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 390a00f (Wed Sep 01 02:26:33 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
HuangXingBo
reviewed
Sep 1, 2021
| # cython: profile=True | ||
| # cython: boundscheck=False, wraparound=False, initializedcheck=False, cdivision=True | ||
| from types import GeneratorType | ||
| from typing import Iterable |
Contributor
There was a problem hiding this comment.
change to from collections import Iterable, Generator?
| # cython: infer_types = True | ||
| # cython: profile=True | ||
| # cython: boundscheck=False, wraparound=False, initializedcheck=False, cdivision=True | ||
| from types import GeneratorType |
Contributor
There was a problem hiding this comment.
put these two imports together with other python imports
|
|
||
| import datetime | ||
| import decimal | ||
| from types import GeneratorType |
Contributor
There was a problem hiding this comment.
change to from collections import Iterable, Generator and put this import after the import struct
HuangXingBo
approved these changes
Sep 2, 2021
dianfu
added a commit
that referenced
this pull request
Sep 2, 2021
…ult is a generator of Row This closes #17090.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation