Skip to content

Conversation

@Myracle
Copy link
Contributor

@Myracle Myracle commented Sep 13, 2021

What is the purpose of the change

This pull request adds end-to-end test for pulsar source.

Brief change log

  • Add submodule flink-end-to-end-pulsar
  • Add class PulsarSourceE2ECase to test exclusive and failover SubscriptionType
  • SubscriptionType Shared and Key_Shared are complex and will be tested later
  • Related code in flink-connectors/flink-connectors-pulsar is modified

Verifying this change

This change added tests and can be verified as follows:

  • Extended integration test for pulsar source in different SubscriptionType

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4dea0cf (Mon Sep 13 18:39:14 UTC 2021)

Warnings:

  • 3 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 13, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@syhily
Copy link
Contributor

syhily commented Sep 13, 2021

I have submitted another PR for the e2e test on Pulsar. Which contains all the test cases on four types of Pulsar subscription. I think we can close this one.

@Myracle Myracle force-pushed the FLINK-23969-pulsar-source-end-to-end-test branch from 4dea0cf to 05edbd6 Compare September 14, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants