[FLINK-24291][table-planner]Decimal precision is lost when deserializing in test cases #17308

xuyangzhong · 2021-09-17T04:11:55Z

What is the purpose of the change

Get the correct converter which is used to deserialize a decimal field by setting it the correct precision information.

Brief change log

It caused by the different code route between executing actual sql examples and testing test cases. So mainly change the code in TestRowDataCsvInputFormat.

Replace the TypeInformation which doesn't contain precision info with DataType which contains.
Add some test case in FileSystemITCaseBase

Verifying this change

The test case added can verify this change.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented?

flinkbot · 2021-09-17T04:26:19Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 2fcfaeb (Fri Sep 17 04:26:19 UTC 2021)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2021-09-17T04:59:36Z

CI report:

8bab59e UNKNOWN
68773af Azure: SUCCESS Azure: CANCELED

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run azure re-run the last Azure build

xuyangzhong · 2021-09-17T06:22:49Z

@flinkbot run azure

godfreyhe

Thanks for the contribution @xuyangzhong , LGTM overall

godfreyhe · 2021-09-18T06:29:47Z

...table-runtime/src/test/java/org/apache/flink/table/filesystem/TestRowDataCsvInputFormat.java

                        .collect(Collectors.toList());
+        RowTypeInfo rowType = (RowTypeInfo) schema.toRowType();
+        List<TypeInformation> fieldTypeInfos = Arrays.asList(rowType.getFieldTypes());
+        List<TypeInformation> csvSelectTypeInfos =


nit: this field can be converted to array directly

godfreyhe · 2021-09-18T06:32:20Z

...ble-planner/src/test/scala/org/apache/flink/table/planner/runtime/FileSystemITCaseBase.scala

+  }
+
+  @Test
+  def testSelectDecimalWithPrecisionTenAndZeroFromFileSystem(): Unit={


"FromCsv" is more correct

This is because now all test case is in Base, the specific subClass define the implements from avo, csv, json and etc.So if I follow the test behavior before, I think the name "FromFileSystem" is suit for this function. However, if I take this case to "FileSystemTestCsvITCase" or "StreamFileSystemTestCsvITCase", i need to rewrite the same test case twice time(and now subClass that contains these two class doesn't have any test cases at all).

xuyangzhong · 2021-09-22T05:40:17Z

@flinkbot run azure

xuyangzhong · 2021-09-22T11:33:41Z

@flinkbot run azure

xuyangzhong · 2021-09-23T01:38:13Z

@flinkbot run azure

xuyangzhong · 2021-09-23T03:09:30Z

@flinkbot run azure

…erializing records from testcsv This closes apache#17308 (cherry picked from commit 4d69f7f)

…zing records from testcsv This closes apache#17308 (cherry picked from commit 4d69f7f)

…zing records from testcsv This closes apache#17308

rmetzger added review=description? component=TableSQL/Planner labels Sep 17, 2021

godfreyhe reviewed Sep 18, 2021

View reviewed changes

xuyangzhong added 3 commits September 22, 2021 12:31

[FLINK-24291][table-planner]Decimal precision is lost when deserializing

890c730

rename test function

2331d62

create the test table with decimal(3,2) field to to test

f82397b

xuyangzhong force-pushed the 210917-flinkjr-24291 branch from 3474817 to c01a08e Compare September 22, 2021 04:35

xuyangzhong force-pushed the 210917-flinkjr-24291 branch 2 times, most recently from 765eb79 to 32155a2 Compare September 23, 2021 01:30

xuyangzhong force-pushed the 210917-flinkjr-24291 branch from 32155a2 to f82397b Compare September 23, 2021 02:04

turn list to array

68773af

godfreyhe approved these changes Oct 9, 2021

View reviewed changes

godfreyhe closed this in 4d69f7f Oct 9, 2021

godfreyhe pushed a commit to godfreyhe/flink that referenced this pull request Oct 9, 2021

[FLINK-24291][table-planner-blink] Decimal precision is lost when des…

87a3e2e

…erializing records from testcsv This closes apache#17308 (cherry picked from commit 4d69f7f)

godfreyhe pushed a commit to godfreyhe/flink that referenced this pull request Oct 9, 2021

[FLINK-24291][table-planner] Decimal precision is lost when deseriali…

3e0c2a1

…zing records from testcsv This closes apache#17308 (cherry picked from commit 4d69f7f)

niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022

[FLINK-24291][table-planner] Decimal precision is lost when deseriali…

a85cc49

…zing records from testcsv This closes apache#17308

[FLINK-24291][table-planner]Decimal precision is lost when deserializing in test cases #17308

[FLINK-24291][table-planner]Decimal precision is lost when deserializing in test cases #17308

Uh oh!

Conversation

xuyangzhong commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

Uh oh!

flinkbot commented Sep 17, 2021

Automated Checks

Review Progress

Uh oh!

flinkbot commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI report:

Uh oh!

xuyangzhong commented Sep 17, 2021

Uh oh!

godfreyhe left a comment

Choose a reason for hiding this comment

Uh oh!

godfreyhe Sep 18, 2021

Choose a reason for hiding this comment

Uh oh!

godfreyhe Sep 18, 2021

Choose a reason for hiding this comment

Uh oh!

xuyangzhong Sep 18, 2021

Choose a reason for hiding this comment

Uh oh!

godfreyhe Sep 22, 2021

Choose a reason for hiding this comment

Uh oh!

xuyangzhong commented Sep 22, 2021

Uh oh!

xuyangzhong commented Sep 22, 2021

Uh oh!

xuyangzhong commented Sep 23, 2021

Uh oh!

xuyangzhong commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xuyangzhong commented Sep 17, 2021 •

edited

Loading

flinkbot commented Sep 17, 2021 •

edited

Loading