[FLINK-3486] [tableAPI] Fix broken renaming of all fields.#1738
Closed
fhueske wants to merge 2 commits intoapache:tableOnCalcitefrom
Closed
[FLINK-3486] [tableAPI] Fix broken renaming of all fields.#1738fhueske wants to merge 2 commits intoapache:tableOnCalcitefrom
fhueske wants to merge 2 commits intoapache:tableOnCalcitefrom
Conversation
| if(relNode == projected) { | ||
| // Calcite's RelBuilder does not translate identity projects even if they rename fields. | ||
| // Add a projection ourselves (will be automatically removed by translation rules). | ||
| val names = exprs.map(_.asInstanceOf[RexCall].getOperands.get(1) |
Contributor
There was a problem hiding this comment.
This cast to RexCall seems to cause several tests to fail.
Contributor
Author
There was a problem hiding this comment.
Woops!
Thanks, I'll check that.
Contributor
Author
|
I fixed the failing tests. |
Contributor
Author
|
Will merge this to |
Contributor
Author
|
Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.