Skip to content

Conversation

@matriv
Copy link
Contributor

@matriv matriv commented Oct 6, 2021

What is the purpose of the change

Following calcite-avatica behaviour, fix the behaviour of parsing
string into unix time when the string is incomplete, missing 1 or
both : time units separator. Previously, minutes and seconds where
set to default value 1 instead of 0 when missing from the parsed
string. Issue was fixed in avatica with: apache/calcite-avatica@cac2ffa

Brief change log

  • Apply the fix for parsing strings into time as in calcite-avatica

Verifying this change

This change added tests and can be verified as follows:

  • Changed tests for CASTing string to TIME() which uses the method in question
  • Added more tests to demonstrate better the behaviour for such edge cases

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Following calcite-avatica behaviour, fix the behaviour of parsing
string into unix time when the string is incomplete, missing 1 or
both `:` time units separator. Previously, minutes and seconds where
set to default value `1` instead of `0` when missing from the parsed
string. Issue was fixed in avatica with: apache/calcite-avatica@cac2ffa
@flinkbot
Copy link
Collaborator

flinkbot commented Oct 6, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e024d45 (Wed Oct 06 09:42:56 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 6, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once the build is green

@twalthr twalthr closed this in 18ffed7 Oct 7, 2021
@matriv matriv deleted the FLINK-24421 branch October 7, 2021 14:30
niklassemmler pushed a commit to niklassemmler/flink that referenced this pull request Feb 3, 2022
Following calcite-avatica behaviour, fix the behaviour of parsing
string into unix time when the string is incomplete, missing 1 or
both `:` time units separator. Previously, minutes and seconds where
set to default value `1` instead of `0` when missing from the parsed
string. Issue was fixed in avatica with:
apache/calcite-avatica@cac2ffa

This closes apache#17418.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants