[FLINK-3578] Support RichFunctions for Scala Window Function and AllWindowFunction#1765
Closed
StephanEwen wants to merge 1 commit into
Closed
[FLINK-3578] Support RichFunctions for Scala Window Function and AllWindowFunction#1765StephanEwen wants to merge 1 commit into
StephanEwen wants to merge 1 commit into
Conversation
Contributor
|
Looks very good! 👍 |
Contributor
|
One thing is that we should maybe have tests/ITCases that verify that rich functions actually work. |
Contributor
Author
|
Yes, have started in tests already... |
…Function and AllWindowFunction This also consolidates the various wrapper classes for fold() and reduce() functions.
Contributor
Author
|
Tests have been added for RichWindowFunctions, plus for combinations with Reduce and Fold for pre-aggregation. Merging this... |
StephanEwen
added a commit
to StephanEwen/flink
that referenced
this pull request
Mar 4, 2016
…Function and AllWindowFunction This also consolidates the various wrapper classes for fold() and reduce() functions. This closes apache#1765
StephanEwen
added a commit
to StephanEwen/flink
that referenced
this pull request
Mar 4, 2016
…Function and AllWindowFunction This also consolidates the various wrapper classes for fold() and reduce() functions. This closes apache#1765
subhankarb
pushed a commit
to subhankarb/flink
that referenced
this pull request
Mar 17, 2016
…Function and AllWindowFunction This also consolidates the various wrapper classes for fold() and reduce() functions. This closes apache#1765
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support RichFunctions for Scala Window Function and AllWindowFunction.
RichFunction method calls (
open(),close(),RuntimeContext) are properly forwarded.This also consolidates the various wrapper classes for fold() and reduce() functions.