Skip to content

Conversation

@XComp
Copy link
Contributor

@XComp XComp commented Nov 16, 2021

There's going to be a parsing issue reported if no parameter is passed due to
the if condition being rendered to [ == '1' ]. Adding the quotes fixes this
problem.

This is not really an issue in CI because we always pass a parameter. The README.md, though, still states calling this script without a parameter which reveals the issue.

What is the purpose of the change

Fixing this issue removes the warning that is printed when calling flink-end-to-end-tests/run-nightly-tests.sh without a parameter:

$ FLINK_DIR=build-target/ ./flink-end-to-end-tests/run-nightly-tests.sh
[...]
==============================================================================
Running bash end-to-end tests
==============================================================================
flink-end-to-end-tests/run-nightly-tests.sh: line 268: [: ==: unary operator expected
flink-end-to-end-tests/run-nightly-tests.sh: line 270: [: ==: unary operator expected
[...]

Brief change log

Adds quotes

Verifying this change

Testted manually

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

There's going to be a parsing issue reported if no parameter is passed due to
the if condition being rendered to [ == '1' ]. Adding the quotes fixes this
problem.
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 16, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit ae63bca (Tue Nov 16 21:38:48 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zentol zentol merged commit 10c7a78 into apache:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants