[FLINK-3503] [tableAPI] Add cost model for DataSet RelNodes to improve plan selection #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e plan selection.
| val child = this.getInput | ||
| val rowCnt = RelMetadataQuery.getRowCount(child) | ||
| val exprCnt = calcProgram.getExprCount | ||
| planner.getCostFactory.makeCost(rowCnt, rowCnt * exprCnt, 0) |
Contributor
Author
There was a problem hiding this comment.
Calc is implemented as MapFunction and will never spill to disk or cause network traffic.
Contributor
|
Merging this one too. |
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2016
…e plan selection. This closes #1798
Contributor
|
merged :)) |
vasia
pushed a commit
to vasia/flink
that referenced
this pull request
Mar 16, 2016
…e plan selection. This closes apache#1798
asfgit
pushed a commit
that referenced
this pull request
Mar 18, 2016
…e plan selection. This closes #1798
fijolekProjects
pushed a commit
to fijolekProjects/flink
that referenced
this pull request
May 1, 2016
…e plan selection. This closes apache#1798
hequn8128
pushed a commit
to hequn8128/flink
that referenced
this pull request
Jun 22, 2017
…e plan selection. This closes apache#1798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calcite's default cost model does not take IO and CPU into account. As a consequence, projections are not pushed down (as described in FLINK-3503).
This PR adds a basic cost model to push filters and projections towards the sources.