Skip to content

Conversation

@echauchot
Copy link
Contributor

This PR is the backport of this merged PR to release 1.13.

For DockerImageVersions it was not present in release 1.13 so I inlined in the test:
private static final String CASSANDRA_3 = "cassandra:3.0";

R: @zentol

@echauchot
Copy link
Contributor Author

@flinkbot run azure

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5b15a6a (Fri Dec 17 12:10:06 UTC 2021)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 17, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@echauchot
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@echauchot
Copy link
Contributor Author

@flinkbot run azure

@echauchot
Copy link
Contributor Author

@zentol I always get the AZP tests cancelled, do you know what's going on ?

@tillrohrmann tillrohrmann force-pushed the FLINK-25147-cassandra-test-containers-1.13 branch from 5b15a6a to 0b30780 Compare December 21, 2021 14:54
@tillrohrmann tillrohrmann merged commit 0b30780 into apache:release-1.13 Dec 21, 2021
@echauchot
Copy link
Contributor Author

thanks @tillrohrmann for merging !

@echauchot echauchot deleted the FLINK-25147-cassandra-test-containers-1.13 branch December 22, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants