-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-25590][metrics] Introduce RequestedMemoryUsage and log warnings if usage exceeds 100% #18392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7a2cc90 (Tue Jan 18 10:41:54 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
Show resolved
Hide resolved
...ime/src/main/java/org/apache/flink/runtime/io/network/metrics/NettyShuffleMetricFactory.java
Show resolved
Hide resolved
…s if usage exceeds 100%
…warnings if usage exceeds 100%
akalash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@flinkbot run azure |
|
Ops, I forgot to squash commits before merging :| |
Right now, if exclusive buffers for the input channel and one buffer for each subpartition would be allocated on start successfully but there would be not enough memory for the rest of the buffers(floating buffers, rest buffers for subpartitions), then we see nothing in the log about that(as I understand).
So first of all, we need to check what logs we have right now about situations when flink doesn't have enough memory for all configured buffers. And if we have nothing (or not enough) we should add such a log.
Verifying this change
Added a dedicated unit test
Manually tested in an end to end example.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation