-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-15130] Drop 'RequiredParameters' and 'Options' #18440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2976dd3 (Fri Jan 21 12:11:18 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
@flinkbot run azure |
RocMarshal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice~. @snuyanzin
LGTM +1. (non-binding.)
|
@snuyanzin The change looks good to me, too. May you rebase the PR. It seems that there was a junit5 migration for those tests that are conflicting now? |
|
Thanks for the feedback, rebased |
XComp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change @snuyanzin and @RocMarshal for reviewing this PR. I'm going to go ahead and merge the change.
What is the purpose of the change
The PR drops deprecated classes
flink-java/src/main/java/org/apache/flink/api/java/utils/Option.javaflink-java/src/main/java/org/apache/flink/api/java/utils/OptionType.javaflink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParameters.javaflink-java/src/main/java/org/apache/flink/api/java/utils/RequiredParametersException.javaflink-java/src/test/java/org/apache/flink/api/java/utils/OptionsTest.javaflink-java/src/test/java/org/apache/flink/api/java/utils/RequiredParametersTest.javaVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation