-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-25807][rest][docs] Deduplicate fields that only differ by naming convention #18507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit fbc6046 (Tue Jan 25 14:23:57 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
Note: this issue has been introduce by https://issues.apache.org/jira/browse/FLINK-13949 |
|
Hmm, it dates back even further -> https://issues.apache.org/jira/browse/FLINK-11232 @zentol I'm wondering, should we rather fix this in the UI and get rid of the duplicate field? |
|
Second thoughts, we want to avoid a breaking change here. Would it be possible to leverage the swagger annotation here instead? |
… by naming convention" This reverts commit fbc6046.
It's not a breaking change in any case. The REST API still responds with both fields and existing clients will continue to work. Any code written against the new client is, well, new, and thus can't be broken.
Yes, this is possible. I forgot that we directly pass the request/response bodies to swagger. |
dmvk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
No description provided.