Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Jan 25, 2022

No description provided.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit fbc6046 (Tue Jan 25 14:23:57 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 25, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dmvk
Copy link
Member

dmvk commented Jan 27, 2022

Note: this issue has been introduce by https://issues.apache.org/jira/browse/FLINK-13949

@dmvk
Copy link
Member

dmvk commented Jan 27, 2022

Hmm, it dates back even further -> https://issues.apache.org/jira/browse/FLINK-11232

@zentol I'm wondering, should we rather fix this in the UI and get rid of the duplicate field?

@dmvk
Copy link
Member

dmvk commented Jan 27, 2022

Second thoughts, we want to avoid a breaking change here. Would it be possible to leverage the swagger annotation here instead?

eg. https://docs.swagger.io/swagger-core/v1.5.0/apidocs/io/swagger/annotations/ApiModelProperty.html#hidden()

@zentol
Copy link
Contributor Author

zentol commented Jan 28, 2022

we want to avoid a breaking change here

It's not a breaking change in any case. The REST API still responds with both fields and existing clients will continue to work. Any code written against the new client is, well, new, and thus can't be broken.

Would it be possible to leverage the swagger annotation

Yes, this is possible. I forgot that we directly pass the request/response bodies to swagger.

Copy link
Member

@dmvk dmvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zentol zentol merged commit e2f609c into apache:master Jan 28, 2022
@zentol zentol deleted the 25807 branch February 22, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants