Skip to content

Conversation

@JingGe
Copy link
Contributor

@JingGe JingGe commented Feb 7, 2022

What is the purpose of the change

Replace deprecated class, update doc, and fix typos

Brief change log

  • Refactoring - replace the deprecated ParquetAvroWriters with the AvroParquetWriters
  • Update doc to use AvroParquetWriters
  • typos fix in StreamExecutionEnvironment

Verifying this change

This change is a code and doc cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

@JingGe JingGe changed the title Hotfix replace deprecated class and fix typos [HOTFIX] replace deprecated class and fix typos Feb 7, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 7, 2022

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 55418da (Mon Feb 07 10:59:01 UTC 2022)

Warnings:

  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 7, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JingGe
Copy link
Contributor Author

JingGe commented Feb 7, 2022

@flinkbot run azure

@JingGe JingGe changed the title [HOTFIX] replace deprecated class and fix typos [hotfix][docs] replace deprecated class and fix typos Feb 7, 2022
@JingGe
Copy link
Contributor Author

JingGe commented Feb 8, 2022

@flinkbot run azure

1 similar comment
@JingGe
Copy link
Contributor Author

JingGe commented Feb 8, 2022

@flinkbot run azure

@leonardBang leonardBang self-requested a review February 9, 2022 06:34
Copy link
Contributor

@dawidwys dawidwys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dawidwys dawidwys merged commit ea86a80 into apache:master Feb 10, 2022
@JingGe JingGe deleted the hotfix-typos branch February 10, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants