Skip to content

[FLINK-25976][connectors/kinesis] Updating the default number of in f…#18652

Closed
CrynetLogistics wants to merge 1 commit intoapache:masterfrom
CrynetLogistics:FLINK-25976
Closed

[FLINK-25976][connectors/kinesis] Updating the default number of in f…#18652
CrynetLogistics wants to merge 1 commit intoapache:masterfrom
CrynetLogistics:FLINK-25976

Conversation

@CrynetLogistics
Copy link
Copy Markdown
Contributor

…light records to 50

What is the purpose of the change

Updating default values for KinesisDataStreams Sink

Brief change log

Updated default values for KinesisDataStreams Sink

Verifying this change

trivial chg

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)n
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)n
  • The serializers: (yes / no / don't know)n
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)n
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)n
  • The S3 file system connector: (yes / no / don't know)n

Documentation

  • Does this pull request introduce a new feature? (yes / no)n
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)jdocs

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Feb 7, 2022

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 10774e6 (Mon Feb 07 20:07:39 UTC 2022)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Feb 7, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@dannycranmer
Copy link
Copy Markdown
Contributor

LGTM merged c0594583c

MrWhiteSike pushed a commit to MrWhiteSike/flink that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants