[FLINK-26006][connector-aws-kinesis-firehose] Avoid leaking AWS SDK r…

[dmvk]

https://issues.apache.org/jira/browse/FLINK-26006

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 0f18fcb (Tue Feb 08 11:17:21 UTC 2022)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• c4089d5 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[dmvk]

cc @dannycranmer

[zentol]

review would've been easier if the renamings wouldn't be there :)

[dmvk]

I wanted to make explicit that EVERY SINGLE CALL to these methods, create a resource that needs to be closed.

[zentol]

that's a fair point!

[zentol]

This looks fine to me; but I'm very concerned that something as basic as closing clients isn't being done.
We should probably verify the whole module in that case...

[dmvk]

@zentol @dannycranmer The very same problem is with other AWS code that has been added recently.

[dmvk]

@dannycranmer This can backfire at any time (and it already did, but the docker cache hides it on CI). Same should apply for the kinesis above.

[dannycranmer]

Ack, thanks for the spot. We will update the kinesalite image https://issues.apache.org/jira/browse/FLINK-26008

[dannycranmer]

@zentol apologies this was missed on the first PRs, however we had detected and raised a Jira to fix it https://issues.apache.org/jira/browse/FLINK-25977