Skip to content

Conversation

@adiaixin
Copy link

…ookupFunction In SQL that indirect extends (Async)TableFunction, throw exception

What is the purpose of the change

when implements the LookupFunction In SQL that indirect extends (Async)TableFunction, we extract the output type class use ExtractionUtils#extractSimpleGeneric, this method will return empty when dealing with indirect extended subclasses. We need to fix this bug.

Brief change log

  • change method ExtractionUtils#extractSimpleGeneric, traverse all the super classes to the base class until find the generic parameter in pos has real class type.

Verifying this change

(Please pick either of the following options)

This change added tests and can be verified as follows:

  • Added a unit Test which verified the static method result. (org.apache.flink.table.utils.ExtractionUtilsTest)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants