Skip to content

Conversation

@rkhachatryan
Copy link
Contributor

What is the purpose of the change

The current semantics of ChangelogWriter.lastAppendedSqn doesn't allow
to distinguish between initial empty and non-empty states.
This results in wrong SQN passed to truncate and persist methods.

This change solves this by replacing lastAppendedSqn with nextSqn.
It essentially moves the responsibility to call sqn.next() on materialization
from backend to writer which has the knowledge of whether there were any changes or not.

Verifying this change

ProcessingTimeWindowCheckpointingITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@rkhachatryan rkhachatryan requested a review from Myasuka February 11, 2022 15:59
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 0915277 (Fri Feb 11 16:01:05 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 11, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR!
LGTM on the whole.

The current semantics of ChangelogWriter.lastAppendedSqn doesn't allow
to distinguish between initial empty and non-empty states.
This results in wrong SQN passed to truncate and persist methods.

This change solves this by replacing lastAppendedSqn with nextSqn.
It essentially moves the responsibility to call sqn.next() on materialization
from backend to writer which has the knowledge of whether there were any changes or not.
@rkhachatryan rkhachatryan merged commit 66048d1 into apache:master Feb 12, 2022
@rkhachatryan rkhachatryan deleted the f25987-next branch February 12, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants