Skip to content

Conversation

@wuchong
Copy link
Member

@wuchong wuchong commented Feb 12, 2022

What is the purpose of the change

Currently, the communitcation between Operator and Coordiator is sigle-way. That means, after Operator sending a message to Coordiator, it can't wait to get the response message. In some senarios, the Operator may need to retrieve some information stored in the Coordinator. Thus, it would be great if we can have a two-way communication.

Brief change log

  • Add sendRequestToCoordinator(..) interface to TaskOperatorEventGateway which accepts a request and returns a response future. The TaskOperatorEventGateway can be obtained by opereator used to communicate with coordinator.
  • Add sendRequestToCoordinator iterface to JobMasterOperatorEventGateway as the RPC method for Task to JM. JobMaster implement the interface to handover the request to correspond OperatorCoordinator.
  • Users' OperatorCoordinator should implement CoordinationRequestHandler interface (already exist) to handle the received requests. CollectSinkOperatorCoordinator already does it in this way.

Verifying this change

  • Added integration test in CoordinatorEventsExactlyOnceITCase
  • Added unit test in TaskExecutorOperatorEventHandlingTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 1d6f803 (Sat Feb 12 04:02:58 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 12, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@wuchong
Copy link
Member Author

wuchong commented Feb 12, 2022

@gaoyunhaii could you help to review this? when you are available. very appreciated it.

@gaoyunhaii
Copy link
Contributor

@wuchong Thanks for the PR! I'll have a look~

@gaoyunhaii gaoyunhaii self-requested a review February 14, 2022 02:13
Copy link
Contributor

@gaoyunhaii gaoyunhaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuchong for the PR! I only have two minor comments.

}
}

// this one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unnecessary?

void sendOperatorEventToCoordinator(OperatorID operator, SerializedValue<OperatorEvent> event);

/**
* Send a request from current operator to a specified operator coordinator which is identified
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send -> Sends ?

@wuchong
Copy link
Member Author

wuchong commented Feb 15, 2022

Thanks @gaoyunhaii for the reviewing. I have addressed the comments and will merge it once the CI passed.

@wuchong wuchong merged commit fdb8010 into apache:master Feb 15, 2022
@wuchong wuchong deleted the op-co-request branch February 15, 2022 15:29
MrWhiteSike pushed a commit to MrWhiteSike/flink that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants