[FLINK-2544] Add Java 8 version for building PowerMock tests to docs#1882
Closed
skavulya wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-2544] Add Java 8 version for building PowerMock tests to docs#1882skavulya wants to merge 1 commit intoapache:masterfrom
skavulya wants to merge 1 commit intoapache:masterfrom
Conversation
Java 8 update 11 introduced a stricter bytecode verifier that leads to failures in unit tests that use the PowerMock runner. The tests run correctly in Java 8u51 or above.
Contributor
|
Thanks for the fix, @skavulya! |
Contributor
|
Will merge this PR. |
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
Apr 15, 2016
…o docs Java 8 update 11 introduced a stricter bytecode verifier that leads to failures in unit tests that use the PowerMock runner. The tests run correctly in Java 8u51 or above. This closes apache#1882
Contributor
|
As a followup, could we add some "Assume" statements in the tests that check whether the Java version is either Java 7 or Java 8u51+ ? |
Contributor
Author
|
@StephanEwen Adding "Assume" statements is a good idea. We could limit them to the affected tests. |
kl0u
pushed a commit
to kl0u/flink
that referenced
this pull request
Apr 29, 2016
…o docs Java 8 update 11 introduced a stricter bytecode verifier that leads to failures in unit tests that use the PowerMock runner. The tests run correctly in Java 8u51 or above. This closes apache#1882
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java 8 update 11 introduced a stricter bytecode verifier that leads to failures in unit tests that use the PowerMock runner. The tests run correctly in Java 8u51 or above. This PR updates the README with a note about the Java versions needed to run unit tests that use the PowerMock runner.