Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Feb 17, 2022

Based on #18817.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 11750c8 (Thu Feb 17 12:10:04 UTC 2022)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 17, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@RyanSkraba RyanSkraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, but everything else LGTM: no unnecessary public for classes and test methods, no org.junit imports that aren't jupiter, no matchers that aren't org.assertj and the TestLogger extension is no longer used.

zentol and others added 5 commits February 17, 2022 22:50
…nk/metrics/slf4j/Slf4jReporterTest.java

Co-authored-by: Ryan Skraba <ryan@skraba.com>
…nk/metrics/slf4j/Slf4jReporterTest.java

Co-authored-by: Ryan Skraba <ryan@skraba.com>
…nk/metrics/slf4j/Slf4jReporterTest.java

Co-authored-by: Ryan Skraba <ryan@skraba.com>
@zentol zentol merged commit 8d050ae into apache:master Feb 18, 2022
@zentol zentol deleted the 26219 branch February 22, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants