Skip to content

Conversation

@slinkydeveloper
Copy link
Contributor

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 43905df (Tue Feb 22 14:35:15 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 22, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@slinkydeveloper
Copy link
Contributor Author

slinkydeveloper commented Feb 22, 2022

@twalthr seems like when the flag is deprecated, the docs generator ignores it. At least, i tried to generate, but nothing changed. Perhaps for this flag is better to not show it in the docs? WDYT?

…ds' to support old transformation uid generation behaviour

Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slinkydeveloper. Can we add at least one test for this? I think org.apache.flink.table.planner.plan.nodes.exec.TransformationsTest would be a good location to quickly check a pipeline from source -> one or two operators -> sink.

Not having it in the docs is fine with me.

Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slinkydeveloper
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
@twalthr twalthr closed this in c6d27ba Mar 2, 2022
@slinkydeveloper slinkydeveloper deleted the FLINK-26280 branch March 2, 2022 13:27
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
…ds' to support old transformation uid generation behaviour

This closes apache#18879.
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
…ds' to support old transformation uid generation behaviour

This closes apache#18879.
lincoln-lil pushed a commit to lincoln-lil/flink that referenced this pull request Oct 1, 2022
…ds' to support old transformation uid generation behaviour

This closes apache#18879.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants