-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-26280][table-planner] Add 'table.exec.legacy-transformation-uids' to support old transformation uid generation behaviour #18879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 43905df (Tue Feb 22 14:35:15 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
@twalthr seems like when the flag is deprecated, the docs generator ignores it. At least, i tried to generate, but nothing changed. Perhaps for this flag is better to not show it in the docs? WDYT? |
…ds' to support old transformation uid generation behaviour Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
43905df to
1d83b31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @slinkydeveloper. Can we add at least one test for this? I think org.apache.flink.table.planner.plan.nodes.exec.TransformationsTest would be a good location to quickly check a pipeline from source -> one or two operators -> sink.
Not having it in the docs is fine with me.
...in/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java
Outdated
Show resolved
Hide resolved
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
twalthr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@flinkbot run azure |
matriv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
…ds' to support old transformation uid generation behaviour This closes apache#18879.
…ds' to support old transformation uid generation behaviour This closes apache#18879.
…ds' to support old transformation uid generation behaviour This closes apache#18879.
Per discussion here https://issues.apache.org/jira/browse/FLINK-25932