Skip to content

Conversation

@matriv
Copy link
Contributor

@matriv matriv commented Feb 22, 2022

What is the purpose of the change

Introduce ExecNodeConfiguration and make appropriate changes so that all
ExecNodes are using this new class which contains the merged configuration
from the planner with the node's persisted configuration in the JSON plan.

Brief change log

  • Rename function to unwrap rel and get TableConfig
  • Fix imports in scala classes
  • Introduce ExecNodeConfiguration
  • Replace usages of TableConfig with ReadableConfig or at least ExecNodeConfiguration wherever possible.
  • Use tableConfig as name for TableConfig variables

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9f086ad (Tue Feb 22 17:59:43 UTC 2022)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 22, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @matriv. I think this is a good long-term refactoring. I searched for missing usages but could not find any, so I only had minor comments. My biggest comment would be: Let's shorten the names of classes a bit before it is too late ExecNodeConfig and PlannerConfig should do the job. It also fits nicely to TableConfig.

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the refactoring makes sense on its own. Due to DummyExecutionEnvironment the configuration is not forwarded yet, but we can finish this effort in a follow up PR. Let's merge this for now.

…ration

Introduce `ExecNodeConfiguration` and make appropriate changes so that all
`ExecNode`s are using this new class which contains the merged configuration
from the planner with the node's persisted configuration in the JSON plan.

Replace usagess of `TableConfig` with `ReadableConfig` or at least
`ExecNodeConfiguration` wherever possible.
To make clear separation of configurations used, and prepare for future
effort to use `ReadableConfig` instead of `TableConfig` rename variables
and function args that require `TableConfig` to `tableConfig` instead of
plain `config` or `conf`.

Minor code improvements to remove IDE warnings in the touched classes.
To be consistent with `TableConfig`, `ExecNodeConfig`, etc.
@twalthr twalthr closed this in 56da73a Feb 24, 2022
@matriv matriv deleted the FLINK-26297 branch February 24, 2022 08:48
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
…nfig

To be consistent with `TableConfig`, `ExecNodeConfig`, etc.

This closes apache#18888.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants