-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-26297][table-planner][table-runtime] Introduce ExecNodeConfiguration #18888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9f086ad (Tue Feb 22 17:59:43 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
twalthr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @matriv. I think this is a good long-term refactoring. I searched for missing usages but could not find any, so I only had minor comments. My biggest comment would be: Let's shorten the names of classes a bit before it is too late ExecNodeConfig and PlannerConfig should do the job. It also fits nicely to TableConfig.
...-planner/src/test/scala/org/apache/flink/table/planner/match/PatternTranslatorTestBase.scala
Outdated
Show resolved
Hide resolved
...k/table/planner/plan/rules/physical/stream/StreamPhysicalGroupWindowTableAggregateRule.scala
Outdated
Show resolved
Hide resolved
.../flink/table/planner/plan/rules/physical/stream/StreamPhysicalGroupWindowAggregateRule.scala
Outdated
Show resolved
Hide resolved
...e-planner/src/main/scala/org/apache/flink/table/planner/codegen/sort/SortCodeGenerator.scala
Show resolved
Hide resolved
...k/table/planner/plan/rules/physical/stream/StreamPhysicalPythonGroupWindowAggregateRule.java
Outdated
Show resolved
Hide resolved
twalthr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the refactoring makes sense on its own. Due to DummyExecutionEnvironment the configuration is not forwarded yet, but we can finish this effort in a follow up PR. Let's merge this for now.
…ration Introduce `ExecNodeConfiguration` and make appropriate changes so that all `ExecNode`s are using this new class which contains the merged configuration from the planner with the node's persisted configuration in the JSON plan. Replace usagess of `TableConfig` with `ReadableConfig` or at least `ExecNodeConfiguration` wherever possible.
To make clear separation of configurations used, and prepare for future effort to use `ReadableConfig` instead of `TableConfig` rename variables and function args that require `TableConfig` to `tableConfig` instead of plain `config` or `conf`. Minor code improvements to remove IDE warnings in the touched classes.
To be consistent with `TableConfig`, `ExecNodeConfig`, etc.
…nfig To be consistent with `TableConfig`, `ExecNodeConfig`, etc. This closes apache#18888.
What is the purpose of the change
Introduce
ExecNodeConfigurationand make appropriate changes so that allExecNodes are using this new class which contains the merged configurationfrom the planner with the node's persisted configuration in the JSON plan.
Brief change log
ExecNodeConfigurationTableConfigwithReadableConfigor at leastExecNodeConfigurationwherever possible.tableConfigas name forTableConfigvariablesDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation