Skip to content

Conversation

@samaitra
Copy link
Member

@samaitra samaitra commented Apr 17, 2016

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General
    • The pull request references the related JIRA issue
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message
  • Documentation
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@fhueske
Copy link
Contributor

fhueske commented Apr 18, 2016

Thanks for the contribution, @samaitra !
PR looks good to merge.

@zentol
Copy link
Contributor

zentol commented Apr 18, 2016

Merging.

@asfgit asfgit closed this in fabc5f9 Apr 18, 2016
kl0u pushed a commit to kl0u/flink that referenced this pull request Apr 29, 2016
StefanRRichter pushed a commit to StefanRRichter/flink that referenced this pull request May 3, 2016
hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants