-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-25705][docs]Translate "Metric Reporters" page of "Deployment" … #19023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi,@RocMarshal, can you help me to review this PR? |
RocMarshal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChengkaiYang2022 Thanks for the translation.
I'll check it asap.
|
@flinkbot run azure |
RocMarshal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChengkaiYang2022 Thanks for the update. I left some minor comments.
Please let me know what's your opinion.
…to '发送器'. 3.Change '非必须' to '可选的'. 4.Change '()' to '()'
chengkaiyang2025
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback has been accepted.
chengkaiyang2025
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have corrected the mistake, please continue the review.:)
@RocMarshal
RocMarshal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChengkaiYang2022 Thanks for the update. I left some minor comments. PTAL.
Co-authored-by: Roc Marshal <flinker@126.com>
Co-authored-by: Roc Marshal <flinker@126.com>
…nese punctuation errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RocMarshal Thanks for the update,I resolved the problem and fixed some Chinese punctuation mistakes.
|
I notice there are some tables in the page with english coding, would you mind helping to translate it ? |
Co-authored-by: Roc Marshal <flinker@126.com>
Co-authored-by: Roc Marshal <flinker@126.com>
Co-authored-by: Roc Marshal <flinker@126.com>
…to '发送器'. 3.Change '非必须' to '可选的'. 4.Change '()' to '()'
Co-authored-by: Roc Marshal <flinker@126.com>
Co-authored-by: Roc Marshal <flinker@126.com>
…nese punctuation errors
Co-authored-by: Roc Marshal <flinker@126.com>
Co-authored-by: Roc Marshal <flinker@126.com>
Co-authored-by: Roc Marshal <flinker@126.com>
# Conflicts: # docs/content.zh/docs/deployment/metric_reporters.md
…in to Chinese [hotfix][FLINK-25705][docs]Add the related tags on the section titles in the page. [hotfix][FLINK-25705][docs]Fix some typo mistakes. [hotfix][FLINK-25705][docs]Fix some mistakes of anchors links. [hotfix][FLINK-25705][docs]Fix mistake of anchors links. [hotfix][FLINK-25705][docs]1.Fix a metric link issue. 2.Change '采集器' to '发送器'. 3.Change '非必须' to '可选的'. 4.Change '()' to '()' [FLINK-25705][docs][hotfix]remove blank space Co-authored-by: Roc Marshal <flinker@126.com> [FLINK-25705][doc][hotfix]remove blank space Co-authored-by: Roc Marshal <flinker@126.com> [hotfix][FLINK-25705][docs]1.remove blank place [hotfix][FLINK-25705][docs]1.Remove some blank place.2.Fixed some Chinese punctuation errors Remove zh prefix Co-authored-by: Roc Marshal <flinker@126.com> Remove zh prefix Co-authored-by: Roc Marshal <flinker@126.com> Remove zh prefix Co-authored-by: Roc Marshal <flinker@126.com>
# Conflicts: # docs/content.zh/docs/deployment/metric_reporters.md
|
@RocMarshal Please ignore the duplicated commits. I was trying to rebase the commits into one commit after merge origin/master to my branch to solve the conflicts(Should not do that). Right now I think I'm unable to rebase these commits. Could I close this pr and pull another request to continue the review? I will the save the newest file in this pr for the new pr. |
…in to Chinese
What is the purpose of the change
Translate "Metric Reporters" page of "Deployment" in to Chinese.
Brief change log
(for example:)
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation