Skip to content

Conversation

@chengkaiyang2025
Copy link
Contributor

…in to Chinese

What is the purpose of the change

Translate "Metric Reporters" page of "Deployment" in to Chinese.

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 9, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@chengkaiyang2025
Copy link
Contributor Author

Hi,@RocMarshal, can you help me to review this PR?

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChengkaiYang2022 Thanks for the translation.
I'll check it asap.

@chengkaiyang2025
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChengkaiYang2022 Thanks for the update. I left some minor comments.

Please let me know what's your opinion.

…to '发送器'. 3.Change '非必须' to '可选的'. 4.Change '()' to '()'
Copy link
Contributor Author

@chengkaiyang2025 chengkaiyang2025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback has been accepted.

Copy link
Contributor Author

@chengkaiyang2025 chengkaiyang2025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected the mistake, please continue the review.:)
@RocMarshal

Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChengkaiYang2022 Thanks for the update. I left some minor comments. PTAL.

Copy link
Contributor Author

@chengkaiyang2025 chengkaiyang2025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RocMarshal Thanks for the update,I resolved the problem and fixed some Chinese punctuation mistakes.

@RocMarshal
Copy link
Contributor

I notice there are some tables in the page with english coding, would you mind helping to translate it ?
Thanks a lot.

chengkaiyang2025 and others added 3 commits March 24, 2022 11:00
Co-authored-by: Roc Marshal <flinker@126.com>
Co-authored-by: Roc Marshal <flinker@126.com>
Co-authored-by: Roc Marshal <flinker@126.com>
@chengkaiyang2025 chengkaiyang2025 marked this pull request as draft March 24, 2022 03:02
@chengkaiyang2025 chengkaiyang2025 marked this pull request as ready for review March 25, 2022 07:57
@chengkaiyang2025 chengkaiyang2025 marked this pull request as draft March 28, 2022 13:06
@chengkaiyang2025 chengkaiyang2025 marked this pull request as ready for review March 28, 2022 13:12
@chengkaiyang2025 chengkaiyang2025 marked this pull request as draft March 28, 2022 13:45
chengkaiyang2025 and others added 2 commits March 28, 2022 21:51
…in to Chinese

[hotfix][FLINK-25705][docs]Add the related tags on the section titles in the page.

[hotfix][FLINK-25705][docs]Fix some typo mistakes.

[hotfix][FLINK-25705][docs]Fix some mistakes of anchors links.

[hotfix][FLINK-25705][docs]Fix mistake of anchors links.

[hotfix][FLINK-25705][docs]1.Fix a metric link issue. 2.Change '采集器' to '发送器'. 3.Change '非必须' to '可选的'. 4.Change '()' to '()'

[FLINK-25705][docs][hotfix]remove blank space

Co-authored-by: Roc Marshal <flinker@126.com>

[FLINK-25705][doc][hotfix]remove blank space

Co-authored-by: Roc Marshal <flinker@126.com>

[hotfix][FLINK-25705][docs]1.remove blank place

[hotfix][FLINK-25705][docs]1.Remove some blank place.2.Fixed some Chinese punctuation errors

Remove zh prefix

Co-authored-by: Roc Marshal <flinker@126.com>

Remove zh prefix

Co-authored-by: Roc Marshal <flinker@126.com>

Remove zh prefix

Co-authored-by: Roc Marshal <flinker@126.com>
# Conflicts:
#	docs/content.zh/docs/deployment/metric_reporters.md
@chengkaiyang2025
Copy link
Contributor Author

@RocMarshal Please ignore the duplicated commits. I was trying to rebase the commits into one commit after merge origin/master to my branch to solve the conflicts(Should not do that).

Right now I think I'm unable to rebase these commits.

Could I close this pr and pull another request to continue the review? I will the save the newest file in this pr for the new pr.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants