Skip to content

[FLINK-26564] Fix the bug that CompactCoordinatorStateHandler doesn't properly handle the cleanup-in-progress requests.#19032

Closed
pltbkd wants to merge 1 commit intoapache:masterfrom
pltbkd:FLINK-26564
Closed

[FLINK-26564] Fix the bug that CompactCoordinatorStateHandler doesn't properly handle the cleanup-in-progress requests.#19032
pltbkd wants to merge 1 commit intoapache:masterfrom
pltbkd:FLINK-26564

Conversation

@pltbkd
Copy link
Copy Markdown
Contributor

@pltbkd pltbkd commented Mar 10, 2022

What is the purpose of the change

This pull request fixes the bug that CompactCoordinatorStateHandler doesn't properly handle the cleanup-in-progress requests.

Brief change log

  • Check with a CompactTrigger if a remaining committable should be compacted or passed through, while CompactCoordinatorStateHandler handling the state.

Verifying this change

This change added tests and can be verified with CompactCoordinatorTest#testStateHandler.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

…torStateHandler doesn't properly handle the cleanup-in-progress requests.
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Mar 10, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@gaoyunhaii gaoyunhaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pltbkd for the fix! LGTM

@gaoyunhaii
Copy link
Copy Markdown
Contributor

@flinkbot run azure

ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink that referenced this pull request Mar 15, 2022
…torStateHandler doesn't properly handle the cleanup-in-progress requests.

This closes apache#19032.
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
…torStateHandler doesn't properly handle the cleanup-in-progress requests.

This closes apache#19032.
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
…torStateHandler doesn't properly handle the cleanup-in-progress requests.

This closes apache#19032.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants