[FLINK-3778] [shell] Forward configuration from FlinkILoop to ScalaShellRemoteStreamEnvironment #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ellRemoteStreamEnvironment With this PR the configuration of the FlinkILoop is properly forwarded to the ScalaShellRemoteStreamEnvironment.
| port, | ||
| this, | ||
| clientConfig, | ||
| getExternalJars(): _*); |
Contributor
|
Changes look good to me. +1 to merge (I did not try it out though). |
Contributor
Author
|
Failing test cases are unrelated. Merging. |
kl0u
pushed a commit
to kl0u/flink
that referenced
this pull request
Apr 29, 2016
…ellRemoteStreamEnvironment With this PR the configuration of the FlinkILoop is properly forwarded to the ScalaShellRemoteStreamEnvironment. This closes apache#1906.
StefanRRichter
pushed a commit
to StefanRRichter/flink
that referenced
this pull request
May 3, 2016
…ellRemoteStreamEnvironment With this PR the configuration of the FlinkILoop is properly forwarded to the ScalaShellRemoteStreamEnvironment. This closes apache#1906.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
mvn clean verifyhas been executed successfully locally or a Travis build has passedWith this PR the configuration of the FlinkILoop is properly forwarded to the
ScalaShellRemoteStreamEnvironment.